Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Null pointer exception in ziflist if network adapters are added/removed whilst being enumerated #1632

Closed
andycbriggs opened this issue Mar 6, 2017 · 4 comments

Comments

@andycbriggs
Copy link
Contributor

andycbriggs commented Mar 6, 2017

Observed a null pointer exception due to polling for ziflist changes whilst adding/removing devices. According to MSDN GetAdapterAddresses may need to be called multiple times in cases where a device has been added/removed.

Note that it is possible for the buffer size required for the IP_ADAPTER_ADDRESSES structures pointed to by the AdapterAddresses parameter to change between subsequent calls to the GetAdaptersAddresses function if an adapter address is added or removed.

From: https://msdn.microsoft.com/en-us/library/windows/desktop/aa365915(v=vs.85).aspx

@bluca
Copy link
Member

bluca commented Mar 6, 2017

Could you please send a PR to fix it?

@andycbriggs
Copy link
Contributor Author

Yes, just in the process of doing so.. #1633

@bluca
Copy link
Member

bluca commented Mar 6, 2017

Great, thanks!

@bluca
Copy link
Member

bluca commented Mar 6, 2017

Fixed by #1633

@bluca bluca closed this as completed Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants