Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to upgrade to Laravel 10 #106

Open
Elliot-putt opened this issue Feb 15, 2023 · 7 comments
Open

Unable to upgrade to Laravel 10 #106

Elliot-putt opened this issue Feb 15, 2023 · 7 comments

Comments

@Elliot-putt
Copy link

   "require": {
        "illuminate/support": "^10.0.0",
        "illuminate/console": "^10.0.0",
        "illuminate/database": "^10.0.0",
        "illuminate/broadcasting": "^10.0.0",
        "illuminate/queue": "^10.0.0",
        "illuminate/container": "^10.0.0"
    },
Composer update error 

- zgabievi/laravel-promocodes 9.1.0 requires illuminate/container ^9.0 -> satisfiable by illuminate/container[v9.0.0-beta.1, ..., 9.x-dev].
    - Root composer.json requires zgabievi/laravel-promocodes ^9.1.0 -> satisfiable by zgabievi/laravel-promocodes[9.1.0].

I'm assuming this is because of the illuminate support version is specified at 9 but it should be 10.

@clickervinod
Copy link

I also waiting Laravel 10 support

@ricardobarantini
Copy link

I'm want to install on Laravel 10 too. Is this package abandoned?

@Elliot-putt
Copy link
Author

I'm want to install on Laravel 10 too. Is this package abandoned?

I wouldn't this still hasn't been updated!

@navigermobile
Copy link

Me too :) :(

@Elshaden
Copy link

Elshaden commented Jul 4, 2023

@ricardobarantini
@Elliot-putt
@ricardobarantini
@zgabievi

I have created a Pull request to upgrade to Laravel 10,
the upgrade will work on both V10 and V9.
so no breaking changes

You are welcome to use my repo
https://github.com/Elshaden/laravel-promocodes.git

you have to add it to your required

"zgabievi/laravel-promocodes":"dev-L10"

You need to add the url also

"repositories": [
       
        {
           "type": "vcs",
           "url": "https://github.com/Elshaden/laravel-promocodes.git"
        }
]

@mgaratemu
Copy link

mgaratemu commented Nov 25, 2023

@Elshaden Do yout think you can add the fix #111 to your repo? I need both of this fixes urgently, and @zgabievi doesn't seems to be active lately to review the pull requests :( thank you in advance

@Elshaden
Copy link

@mgaratemu
Ok Done
I could not Pull your request because it was not made in My repo. so I just copied what you asked for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants