-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reproducing sAP evaluation #24
Comments
Update: guess I found the reason after a day.... After checking the afm code, I found the last column of the output mat (x1,y1,x2,y2,width) is width, instead of the ratio which is used to rank lines in the paper. After replacing last column with width/length, I got new results: mAPJ 23.3 (the same as yours), sAP10: 23.9 (slightly worse than 24.4 in paper). Any ideas on why this happens? |
If the error is relatively small (23.9 vs 24.4), I think it might be due to some subpixel error, e.g., pixels starting from 0 vs from 1 vs from 0.5. @HaozhiQi Any idea on this? |
Another update: Currently the number I got on York is better than yours: (sAP10: 9.1 vs 3.5, mAPJ: 12.3 vs6.9). THis is abit confusing. Not sure where the problem is. Is it possible to realase all numbers (SAP 5 10 15 on both datasets for all methods)? Thanks a lot! |
It seems that your number on York might be reasonable. I will check and get back to you later. |
Sorry for the late reply. The code for evaluating York I am currently using is Line 103 in fdbbf6b
Line 35 in fdbbf6b
|
Cool. I will. Thanks for the reply! |
Feel free to reopen this issue if you have any update. |
HI, Yizhao, Sorry to bother you again. |
Hi @yanconglin, Thank you so much for your finding! I was also wondering the same problem for some time. I will investigate and update our results. Best, |
@yanconglin We have fixed the problem and update the results of the arXiv paper. Thanks for your investigation! |
Hi, Yichao, really nice work! Thanks for sharing the code.
I would like to know how you convert the AFM reuslts (other methods as well) into the npz format which is used in the mAPJ/SAP evaluation? Can you share this part? Currently I have trouble reproducing the reported results of AFM in your paper. The numbes I got are 4.7 6.5 7.6 (sAP on ShanghaiTech), which are ~20 (sAP10) lower than the ones in the paper (Table 2). I have checked that the afm lines and gt lines before the 'lcnn.metric.msTPFP' function are matched by visualization (check the figure below), so I was wondering why the afm result I got is so bad compare with the one in paper? Looking forward to your help!
Thanks in advance!
The text was updated successfully, but these errors were encountered: