Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix theme toggler icon #206

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Fix theme toggler icon #206

merged 1 commit into from
Feb 25, 2022

Conversation

gillisandrew
Copy link
Collaborator

Gatsby had an issue rendering the SVG properly at build time which meant the icon wouldn't display properly until it had been toggled. Forcing it to render on the client-side seems like an acceptable workaround.

@sekwah41 sekwah41 added the bug Something isn't working label Feb 25, 2022
Copy link
Member

@roldanjr roldanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gillisandrew
Copy link
Collaborator Author

Aha Yah This is half done. Interestingly it does resolve the issue (at least in chrome). However the useIsBrowser hook isn't implemented and the actual display issue could probably be resolved with an empty useEffect that forces a re-render on hydration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants