Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make resinator use aro's preprocessor instead of clang #17752

Closed
Tracked by #16270
andrewrk opened this issue Oct 27, 2023 · 0 comments · Fixed by #19174
Closed
Tracked by #16270

make resinator use aro's preprocessor instead of clang #17752

andrewrk opened this issue Oct 27, 2023 · 0 comments · Fixed by #19174
Labels
enhancement Solving this issue will likely involve adding new logic or components to the codebase. os-windows
Milestone

Comments

@andrewrk
Copy link
Member

andrewrk commented Oct 27, 2023

This issue is to eliminate the dependency on clang here:

zig/src/Compilation.zig

Lines 4596 to 4600 in 1c85b0a

if (!build_options.have_llvm) {
return comp.failWin32Resource(win32_resource, "clang not available: compiler built without LLVM extensions", .{});
}
const self_exe_path = comp.self_exe_path orelse
return comp.failWin32Resource(win32_resource, "clang compilation disabled", .{});

const exit_code = try clangMain(arena, argv.items);

Related:

cc @squeek502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Solving this issue will likely involve adding new logic or components to the codebase. os-windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants