Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Routes] Review potential relicts from action suffix removals #4517

Closed
4 tasks
Guite opened this issue Oct 8, 2020 · 2 comments
Closed
4 tasks

[Routes] Review potential relicts from action suffix removals #4517

Guite opened this issue Oct 8, 2020 · 2 comments
Assignees
@Guite
Labels
Refactor
Milestone
3.1.0

Comments

@Guite
Copy link
Member

Guite commented Oct 8, 2020

  • src/system/RoutesModule/Helper/SanitizeHelper.php: sanitizeAction method
  • main controller - selecting controller/action for the main page in "general settings > start page"
  • Routes module - creating custom routes - update code needed?
  • Content module - selecting controller/action for controller elements - update code needed?
@Guite Guite added the Refactor label Oct 8, 2020
@Guite Guite added this to the 3.1.0 milestone Oct 8, 2020
@Guite Guite self-assigned this Oct 8, 2020
@Guite Guite mentioned this issue Oct 8, 2020
Merged
@craigh
Copy link
Member

craigh commented Oct 8, 2020

you created a select method for the start page selector which seems like it could be useful in the routes module at least if not elsewhere.

@craigh
Copy link
Member

craigh commented Dec 28, 2020

refs #4376

@Guite Guite closed this as completed in b0f6f3f Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Guite Guite

Labels
Refactor
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
2 participants
@Guite @craigh