Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify Tag without content #1

Closed
zivillian opened this issue Sep 18, 2018 · 3 comments
Closed

Specify Tag without content #1

zivillian opened this issue Sep 18, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@zivillian
Copy link
Owner

RFC 4511 4.3

ldap.net/ldap/Asn1/Asn1ProtocolOpChoice.cs

Lines 43 to 49 in f4df8fe

/*
* UnbindRequest ::= [APPLICATION 2] NULL
*/
[ExpectedTag(TagClass.Application, 2)]
[AnyValue]
//TODO
public ReadOnlyMemory<byte>? UnbindRequest;

@zivillian zivillian added the enhancement New feature or request label Sep 18, 2018
@zivillian
Copy link
Owner Author

There should be an option to specify that there MUST NOT be any content.

@zivillian
Copy link
Owner Author

Maybe a NoValueAttribute which generates somthing like this:

ldap.net/ldap/Asn1/Generated/Asn1Serializer.cs

Lines 30 to 31 in e53bfcc

reader.ReadNull(new Asn1Tag(TagClass.Application, 2));
reader.ThrowIfNotEmpty();

@zivillian
Copy link
Owner Author

solved by 7d002e3

ldap.net/ldap/Asn1/Asn1ProtocolOp.xml

Line 34 in 7d002e3

<asn:NullValue name="UnbindRequest" implicitTag="2" tagClass="Application"/>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zivillian