-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to revm 3.0 #153
Comments
hi @ziyadedher wonder if you have some capacity for this? revm has gotten some improvements lately and would love to get an update in the table |
Thanks for the bump! Will do this today. I'm on the road and don't have my main computer, so I might just update all the results on my laptop. Either way, relative results should still be stable. |
Benchmarks are running on my laptop now, couldn't get |
I'm seeing some surprising results on my MacBook (maybe ignore
I want to re-run these benchmarks when I'm back at my computer as a sanity check, but digging a bit deeper I see this:
Where In the meantime, @rakita do you have any thoughts on a potential regression here? I think I'm actually seeing a slight regression from the old "release" of @gakonst does this surprise you given how you feel Foundry or Reth perf has been? |
Thx we'll investigate! |
Sounds good! Please keep me in the loop, I definitely wanna make sure that this benchmark suite is not misleading. |
This is expected, we removed one optimization (gas block) for more flexibility in lib usage, I got a little bit less performance degradation as a lot of jump predictions did they work, but i think this is run in docker so it is more effected. I would say run it a few more times (2/3) just to confirm it is similar results and that would be it. |
Dragan released a new Revm version with some perf improvements, https://crates.io/crates/revm
The text was updated successfully, but these errors were encountered: