Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decompression #9

Closed
Divide-By-0 opened this issue Dec 20, 2022 · 1 comment
Closed

Fix decompression #9

Divide-By-0 opened this issue Dec 20, 2022 · 1 comment
Assignees
Labels

Comments

@Divide-By-0
Copy link
Member

Divide-By-0 commented Dec 20, 2022

The .tar.gz decompression step doesn't work -- it compresses fine and uploads fine to the s3 bucket (I think), but when downloading and decompressing (see zkp.ts in targz_frontend branch), the files are bigger than when they were uploaded, and the snarkjs fullProve step gives the error 'zkeyb invalid file format'. This details the error.

Solving this will let us add compressed downloads, halving the download size (decompression is very fast). I think we need to use the zlib library in JS to do this: https://nodejs.org/api/zlib.html#zlib_zlib_unzip_buffer_options_callback .

@Divide-By-0
Copy link
Member Author

Done with #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants