Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on getting signedTransaction in custom chain #337

Open
sifnoc opened this issue Dec 10, 2021 · 2 comments
Open

Error on getting signedTransaction in custom chain #337

sifnoc opened this issue Dec 10, 2021 · 2 comments

Comments

@sifnoc
Copy link
Member

sifnoc commented Dec 10, 2021

In a private chain for testing. the coordinator cannot get a signed transaction, proposes a large size block using the method 'web3.eth.accounts.signTransaction' on web3js v1.2.11

[1639137095499] INFO (1 on b8f920de98df): Picked txs: 15                                                                                                                                      
[1639137095499] INFO (1 on b8f920de98df): Pending txs: 19                                                                                                                                     
[1639137095500] INFO (1 on b8f920de98df): coordinator/coordinator.ts - finalized block 0x595fb99b345d16d788a0be58a49d369869ca51aef81653966c916c34fd19abc7                                     
[1639137095500] INFO (1 on b8f920de98df): Trying to create a child block of 0x36aa0c50de79bbd0a4c4a67419728fd6f1535169839633602a53ea8e0c717b60                                                
[1639137095501] INFO (1 on b8f920de98df): stress-test/coordinator.ts - proposed a new block: 0xe2f1ce95fcb836658a2c1f3a78d8c7eaec167a313c0ed113673350ca727bc643                               
[1639137095542] ERROR (1 on b8f920de98df): coordinator/coordinator.ts - Error occurred during block proposing: Error: Signer Error: gas limit is too low. Need at least 603864   

the reason is that the signTransaction method is using ethereumjs v2.1.2, which rejects less than the minimum amount of gas, baseFee on the ethereumjs-tx, before signing it. but, we are using the estimating gas getting from the ethereum client directly. I believe that it is more accurate than.

I think it is better using @ethereumjs/tx instead of web3.eth.account.signTransaction in contracts/tx-utils.

@chancehudson
Copy link
Member

I think it's worth a try. @ethereumjs/tx is a major version ahead of ethereumjs-tx, it might have fixed transaction gas estimation.

In the meantime I did this to allow the coordinator to propose big blocks 0b88ce9 😅

@sifnoc
Copy link
Member Author

sifnoc commented Dec 15, 2021

In the meantime I did this to allow the coordinator to propose big blocks 0b88ce9 sweat_smile

Found another obstacle for submitting a big block #343

the coordinator could not send a propose transaction over 200 zktx included, then keep trying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants