Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly handle errors in r1cs backend #102

Closed
eightfilms opened this issue Jun 6, 2024 · 1 comment · Fixed by #105
Closed

properly handle errors in r1cs backend #102

eightfilms opened this issue Jun 6, 2024 · 1 comment · Fixed by #105

Comments

@eightfilms
Copy link
Contributor

#100 revealed that in src/backends/r1cs/snarkjs.rs that there are a few places where errors are left unhandled - these should not be silenced like in that PR, but should be properly handled.

Related comments:
#100 (comment)
#100 (comment)

@katat
Copy link
Collaborator

katat commented Jun 6, 2024

Nice spots. I think they are mostly related to file IO errors. We could create some error types in noname to wrap them up for the 3rd party library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants