Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Bigint to figure out if we can remove it #151

Open
mimoo opened this issue Jul 23, 2024 · 3 comments
Open

Document Bigint to figure out if we can remove it #151

mimoo opened this issue Jul 23, 2024 · 3 comments
Labels

Comments

@mimoo
Copy link
Collaborator

mimoo commented Jul 23, 2024

// TODO: get rid of this type tho no?

Screenshot 2024-07-22 at 8 38 48 PM

I can't remember why we had this type, it would be good to spend some time tracking it through the codebase and document exactly what is its purpose. This way we can decide if we want to remove it, or refactor things.

@ronantakizawa
Copy link
Contributor

ronantakizawa commented Aug 26, 2024

BigInt is used in the code to handle very large signed integers that can't be represented by standard fixed-size integer types.

Perhaps we could use Fixed-Size Integer Types or Fixed-size finite field elements?

I was able to replace BigInt with a Field type and have a PR ready for that.

@mimoo
Copy link
Collaborator Author

mimoo commented Aug 26, 2024

I believe the PR mentioned above deletes it :o

@ronantakizawa
Copy link
Contributor

The above PR looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants