alternative for object.create under IE8 #727

[aleen42]

PR for #727

[aleen42]

@zloirock Why can't I see the log of building failed above TravisCI?

[zloirock]

I don't know. It's linting issues, you will have the same with local tests.

[aleen42]

OK, I'll fix the problem mentioned after lint

[aleen42]

I have tested activeXDocument under IE11, which simulates IE8, and found that if I declared it inside NullProtoObject method, this method would be released when AcitiveXObject was released, result in script error. So I have to put it into a more global scope.

[zloirock]

Did you run tests on real IE8? Seems sometimes they are fails.

(fails of JSON and names of .upsert-related methods tests in IE8 is OK)

[aleen42]

What detailed error have you caught? I have no real IE8 for karma to launch to test.

[zloirock]

You could use VMs. You don't need karma for tests. Run npm test for usual CI and bundling all required files - and you could just open tests/tests.html file in IE8.

Details - when I tested, for some unknown reason in ~50% of the page loading some built-ins were unavailable. I don't know - it could be just the network problems or it's the problem with this script - since it's IE and specific environment object. I hadn't enough time for exploring the problem. Little later I'll try to dig deeper.

[aleen42]

I have the same error on the master branch, and the error was thrown when running the following snippet:

var _ref = Reflect || {},
    ownKeys = _ref.ownKeys;

It may be an existed bug before (same after testing under @3.5.0)

[zloirock]

Interesting. I was able to reproduce it too but much less with 50% chance. However, I don't remember any changes that could affect IE8.

[aleen42]

I can reproduce with 100% chance, and I hope I can help you find out later.

[zloirock]

@aleen42 how?

[aleen42]

The same way, but caught Reflect is not defined any time

[zloirock]

I already can't reproduce this problem completely.

[aleen42]

OK, I'll check it later.

[aleen42]

What I need to test is pure.html rather than tests.html.

Real IE8:

Simulating IE8 under IE11:

[zloirock]

The same - no problems.

[aleen42]

👌