Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename global IntersectionObserver object #1

Closed
manniL opened this issue Jan 18, 2019 · 1 comment
Closed

Rename global IntersectionObserver object #1

manniL opened this issue Jan 18, 2019 · 1 comment

Comments

@manniL
Copy link

manniL commented Jan 18, 2019

Hey 👋

You might want to rename window.io to something that's less common or prefix it somehow ☺️

if (isBrowser) window.io = io;

@znck
Copy link
Owner

znck commented Jan 18, 2019

That was not supposed to be there. Forgot to remove.

@znck znck closed this as completed in 8cf3aa7 Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants