Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to configure channel name and description #814

Closed
steelbrain opened this issue Aug 4, 2018 · 6 comments
Closed

Add ability to configure channel name and description #814

steelbrain opened this issue Aug 4, 2018 · 6 comments

Comments

@steelbrain
Copy link
Contributor

Currently it's hard-coded as rn-push-notification-channel and there's no way to configure it :(

See

@steelbrain
Copy link
Contributor Author

Fixed by #822

@tuononh
Copy link

tuononh commented Aug 30, 2018

It's not work and I have to manually modify RNPushNotificationHelper.java.

@steelbrain
Copy link
Contributor Author

Hi @tuononh

This change has not yet been released. Can you please share how you're using it? Also can you also share what you tried and is not working?

@tuononh
Copy link

tuononh commented Sep 11, 2018

@steelbrain: I hard-coded it in RNPushNotificationHelper.java. I tried to modify manifest file as the doc says but it didn't work.

@steelbrain
Copy link
Contributor Author

@tuononh README only works for the latest unreleased stuff, you will have to wait until this is released

Log.w(RNPushNotification.LOG_TAG, "Unable to find " + KEY_CHANNEL_NAME + " in manifest. Falling back to default");

@huangkaiw3n
Copy link

@steelbrain I'm running into this issue as well. Any estimate for the next release? I'm considering my options before making a production update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants