Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Should be one of: ()" message could be more explicit #389

Closed
MoOx opened this issue Dec 18, 2019 · 4 comments
Closed

"Should be one of: ()" message could be more explicit #389

MoOx opened this issue Dec 18, 2019 · 4 comments
Labels

Comments

@MoOx
Copy link
Collaborator

MoOx commented Dec 18, 2019

Feature Request

If the list is empty (no handler correctly added), the message could be more explicit

Why it is needed

  • This will avoid us new users to be confused
  • This will avoid new issue with this "Should be one of: ()"

Possible implementation

Just detect that the list is empty and change the message to something like

No permissions handler detected. Did you linked the one you needed correctly?
Maybe you didn't reinstall the app properly, clean your cache & build & rebuild your app.
@zoontek
Copy link
Owner

zoontek commented Jan 5, 2020

This is tricky since it happens during RCTConvert enum mapping step even before I could check it's value: https://github.com/facebook/react-native/blob/v0.61.5/React/Base/RCTConvert.m#L250

@stale
Copy link

stale bot commented Apr 4, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale label Apr 4, 2020
@stale
Copy link

stale bot commented Apr 11, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Apr 11, 2020
@zoontek
Copy link
Owner

zoontek commented Apr 11, 2020

Fixed in the last version 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants