-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use case results using vim dataset io #4
Comments
Great feedback, thanks @gngrossi . |
We should support
Seems reasonable to me.
Yep, we were thinking of extending the behaviour of editing a directory in vim. E.g
Are you expecting it to be editable? This may be related to the ISPF enqueue support. @MikeFultonDev
I can reproduce, ~it seems to be related to the
|
@MikeFultonDev [SYSA] bash-5.2$ vim "//'@02858.T.CNTL.PDSE(BLUEPASS)'" EDC5028I A previous I/O error has marked the stream invalid for further I/O processing. (errno2=0xC0370005) Press ENTER or type command to continue Are you expecting it to be editable? I did some testing with ISPF and it looks like it is allowed for two different users. But in this use case, I am the same user (@02858), with a session in TSO/ISPF and the other session in SSH. Is the reason for the EDC5028I message? |
I've addressed a couple of the issues in the latest update: https://github.com/ZOSOpenTools/vimport/releases/tag/datasetio
|
Upgraded and re-tested... Works Tried this Good Edit a PDS by mistake No change Being in ISPF BROWSE for a PDSE member [SYSA] bash-5.2$ vim "//'@02858.T.CNTL.PDSE(BLUEPASS)'" Good Error Question: thanks |
The behavior of TSO/ISPF in our sysplex: So, in ISPF BROWSE for a PDSE member and using vim to edit that same member should work the same way... |
Yes, the temporary file is create just before the I/O processing begins. We intercept Vim at that point and dump the dataset contents into the temporary file.
Interesting, thanks. This is reference to the error "EDC5028I A previous I/O error has marked the stream invalid for further I/O processing. (errno2=0xC0370005)" correct? I believe that is coming from fopen, so we'll need to explore further.
|
Regarding the temp file used for editing... for Mike's question... Yes, expecting to be able to vim edit a member when in ISPF BROWSE for that member. |
Ah, that was a design decision, so that we can map the LLQ to a suffix, enabling syntax highlighting to work without any changes to your vimrc. The |
I'm going to open a DSFS case for this...either it's a feature or an issue. Trying to use vim to "browse" or "view" a PDS member when in ISPF edit for that member. ISPF edit on @02858.T.CNTL(GGGG) vim -R /dsfs/txt/@02858/t.cntl/gggg Results: -- INSERT -- W10: Warning: Changing a readonly file Same result for a dataset. |
Case TS017264205 - DSFS Permission Denied when using vim to view a dataset |
@gngrossi for the remaining issues, would it be possible to open separate issues under https://github.com/ZOSOpenTools/vimport/issues ? |
I have to dig into this. I would have expected this to work because we don't honour any ISPF ENQ's yet and I am opening the PDSE as SHR which should work. #6 opened |
This is a side effect of us not honouring the ISPF ENQ's on the dataset. This is covered under #2 |
Opened zopencommunity/vimport#68 |
[SYSA] bash-5.2$ vim //@02858.t.genjcl
SVC99 failure: IKJ56228I DATA SET @[email protected] NOT IN CATALOG OR CATALOG CAN NOT BE ACCESSED .
Press ENTER or type command to continue
For a SVC99 dynamic allocation error, I suggest not to enter vim unless you can be able to run edit commands:
:e "//'@02858.t.genjcl'"
E32: No file name
[SYSA] bash-5.2$ vim "//'@02858.T.ITSV.TBASVC.G0001V00'"
SVC99 failure: IKJ56225I DATA SET @02858.T.ITSV.TBASVC.G0001V00 ALREADY IN USE, TRY LATER+ .
Press ENTER or type command to continue
For the error message, suggest not displaying “SVC99 failure::, just begin with the message id IKJ56225I…
Tried to edit a PDS by mistake…
[SYSA] bash-5.2$ vim "//'@02858.t.cntl'"
1 ^@<98>ÂÓäÅ×Áââ^@^@^L^O^A^C^@^H^A ^E<8f>^A ^E<9f>^T9^@^A^@^A^@^@|ðòøõø@@@@ÃÖÄÅâ@@@
Suggestion: if a PDS/PDSE is entered without a member, maybe run mls @02858.t.cntl instead (if it exists) for a member list?
Being in ISPF BROWSE for a PDSE member
@02858.T.CNTL.PDSE(BLUEPASS) and then trying…to edit
[SYSA] bash-5.2$ vim "//'@02858.T.CNTL.PDSE(BLUEPASS)'"
EDC5028I A previous I/O error has marked the stream invalid for further I/O processing. (errno2=0xC0370005)
Press ENTER or type command to continue
Edit a new PDS member, adding a line, writing it, and exiting (note using _ENCODE_FILE_NEW=IBM-1047)
Going back into edit after…
vim "//'@02858.t.cntl(ggg)'"
1 hello@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@^U
ISPF
BROWSE @02858.T.CNTL(GGG)
Command ===>
ÇÁ%%?
Tried to write an update to the PDS member "//'@02858.t.cntl(ggg)'" after removing the line of data (for an empty member)
"
/tmp/v787420/[email protected]" 0L, 0B written/tmp/v787420/[email protected]" Error: Failed to allocate memory for buffer"
Press ENTER or type command to continue
The text was updated successfully, but these errors were encountered: