Java plain enabler does not provide metadata about z/OS

[pj892031]

All services using Java plain enabler got his message:

2021-11-26 08:59:26.569 <SDKATJ:main:33948876> SDKSERV (org.zowe.apiml.util.ClassOrDefaultProxyUtils:70) WARN Implementation com.ibm.jzos.ZUtil is not available with constructor signature .., it will continue with default one org.zowe.apiml.eurekaservice.client.impl.DefaultCustomMetadataHelper$$Lambda$858/0x00000000897ba730@8b1214b4 : Class org.zowe.apiml.util.ClassOrDefaultProxyUtils can notccess a member of class com.ibm.jzos.ZUtil with modifiers "private"

It means adding metadata about the operating system is out of order. This is not a requirement, just it is good to collect those values.

The reason is class DefaultCustomMetadataHelper uses com.ibm.jzos.ZUtil to fetch data. Class ZUtil has no constructor and all methods are static (see https://www.ibm.com/docs/api/v1/content/SSYKE2_7.0.0/com.ibm.java.zsecurity.api.70.doc/com.ibm.jzos/com/ibm/jzos/ZUtil.html).

api-layer/common-service-core/src/main/java/org/zowe/apiml/util/ClassOrDefaultProxyUtils.java

Line 68 in 6ad9306

return createProxyByConstructor(interfaceClass, implementationClassName, defaultImplementation, new Class[]{}, new Object[]{}, exceptionMappings);

In this particular case will be probably the best solution to create new method like:

    public static <T> T createProxyStatic(Class<T> interfaceClass, String implementationClassName, Supplier<? extends T> defaultImplementation, ExceptionMapping<? extends Exception> ... exceptionMappings) {
        try {
            return createProxy(interfaceClass, implementationClassName, defaultImplementation, new Class[]{}, new Object[]{}, exceptionMappings);
        } catch (ClassNotFoundException | InstantiationException | IllegalAccessException | NoSuchMethodException | InvocationTargetException e) {
            log.warn("Implementation {} is not available with constructor signature {}, it will continue with default one {} : " + e.getLocalizedMessage(),
                implementationClassName, new Class[]{},  defaultImplementation);
        }

        return makeProxy(interfaceClass, defaultImplementation.get(), false, exceptionMappings);
    }

    public static <T> T createProxy(Class<T> interfaceClass, String implementationClassName, Supplier<? extends T> defaultImplementation, Class[] constructorSignature, Object[] constructorParams, ExceptionMapping<? extends Exception> ... exceptionMappings)
        throws ClassNotFoundException {
        ObjectUtil.requireNotNull(interfaceClass, "interfaceClass can't be null");
        ObjectUtil.requireNotEmpty(implementationClassName, "implementationClassName can't be empty");
        ObjectUtil.requireNotNull(defaultImplementation, "defaultImplementation can't be null");
        ObjectUtil.requireNotNull(constructorSignature, "constructorSignature can't be null");
        ObjectUtil.requireNotNull(constructorParams, "constructorParams can't be null");

        final Class<?> implementationClazz = Class.forName(implementationClassName);
        return makeProxy(interfaceClass, implementationClazz, true, exceptionMappings);
    }

Anyway, this will have probably a consequence and it will be also good to check that mapping in this case (implementationClass instanceof java.lang.Class) works only with static methods (disable finding an instance method in this case).

[balhar-jakub]

This seems to be fixed.