Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not require keyAlias #2110

Merged
merged 5 commits into from
Feb 18, 2022
Merged

fix: do not require keyAlias #2110

merged 5 commits into from
Feb 18, 2022

Conversation

achmelo
Copy link
Member

@achmelo achmelo commented Feb 18, 2022

Description

Users will not be required to pass keyAlias. This PR will also make it possible to use two slashes in keyring configuration. It is still preferable to use 4 slashes.

Linked to #2034

Type of change

Please delete options that are not relevant.

  • (fix) Bug fix (non-breaking change which fixes an issue)
  • (feat) New feature (non-breaking change which adds functionality)
  • (docs) Change in a documentation
  • (refactor) Refactor the code
  • (chore) Chore, repository cleanup, updates the dependencies.
  • (BREAKING CHANGE or !) Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@zowe-robot zowe-robot added the Sensitive Sensitive change that requires peer review label Feb 18, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.6% 91.6% Coverage
0.0% 0.0% Duplication

@balhar-jakub balhar-jakub self-requested a review February 18, 2022 14:05
@achmelo achmelo merged commit 03bee79 into master Feb 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the rip/ac/default_private_key branch February 18, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balhar-jakub balhar-jakub balhar-jakub approved these changes

Assignees
No one assigned
Labels
Sensitive Sensitive change that requires peer review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achmelo @balhar-jakub @zowe-robot