fix: Versioning in image publishing workflow #2159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carson Cook <[email protected]>
Signed-off-by: Carson Cook <[email protected]>
Signed-off-by: Carson Cook <[email protected]>
balhar-jakub
approved these changes
Mar 7, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
CarsonCook
added a commit
that referenced
this pull request
Mar 11, 2022
* Fix typo in version input Signed-off-by: Carson Cook <[email protected]> * Improve workflow name Signed-off-by: Carson Cook <[email protected]> * Improve workflow name Signed-off-by: Carson Cook <[email protected]> (cherry picked from commit db52527)
achmelo
pushed a commit
that referenced
this pull request
Mar 11, 2022
* chore: Mocked backend for Metrics Service (#2170) * Add mock backend for auth Signed-off-by: Carson Cook <[email protected]> * Mock SSE metrics Signed-off-by: Carson Cook <[email protected]> * Improve http metrics requests to allow mocking Signed-off-by: Carson Cook <[email protected]> (cherry picked from commit 52df447) * refactor: Refactored PostStoreLoadBalancerCacheFilter and LocationFilter (#2168) * Refactored PostStoreLoadBalancerCacheFilter Signed-off-by: Amanda D'Errico <[email protected]> * Refactored LocationFilter Signed-off-by: Amanda D'Errico <[email protected]> * addressed code review Signed-off-by: Amanda D'Errico <[email protected]> (cherry picked from commit c6f018b) * fix: Improve error handling for API diff endpoint (#2178) * Catch all exceptions for api diff Signed-off-by: Carson Cook <[email protected]> * Refactor unit test names Signed-off-by: Carson Cook <[email protected]> * Minor test refactoring and improvements Signed-off-by: Carson Cook <[email protected]> * Remove unused imports Signed-off-by: Carson Cook <[email protected]> (cherry picked from commit 1581e39) * refactor: Refactoring for gateway.filters classes (#2157) Signed-off-by: Amanda D'Errico <[email protected]> (cherry picked from commit ab36819) * chore: Update permissions after HA run (#2162) * Get debug information Signed-off-by: Jakub Balhar <[email protected]> * List permissions Signed-off-by: Jakub Balhar <[email protected]> * Show hidden directories Signed-off-by: Jakub Balhar <[email protected]> * Test correcting privileges Signed-off-by: Jakub Balhar <[email protected]> * Correct permissions on all HA Signed-off-by: Jakub Balhar <[email protected]> Co-authored-by: Jakub Balhar <[email protected]> (cherry picked from commit 453f4fe) * fix: Versioning in image publishing workflow (#2159) * Fix typo in version input Signed-off-by: Carson Cook <[email protected]> * Improve workflow name Signed-off-by: Carson Cook <[email protected]> * Improve workflow name Signed-off-by: Carson Cook <[email protected]> (cherry picked from commit db52527) Co-authored-by: Amanda D'Errico <[email protected]> Co-authored-by: Jakub Balhar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Carson Cook [email protected]
Description
Improve workflow that publishes test images by fixing version (meaning branch name will be included), and improving workflow name
Linked to # (issue)
Type of change
Please delete options that are not relevant.
Checklist:
For more details about how should the code look like read the Contributing guideline