Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add missing tooltips to all onboarding options #2194

Merged

Conversation

CaioCamatta
Copy link
Contributor

@CaioCamatta CaioCamatta commented Mar 14, 2022

Description

Improved tooltips and suggestions in the onboarding wizard for all onboarding methods.
"As a user trying to onboard a service to API ML, I want to get some better suggestion when using the Wizard UI."

Tasks Complete

  • Enhance properties value helper for Plain Java Enabler
  • Enhance properties value helper for Spring Enabler
  • Enhance properties value helper for Micronaut Enabler
  • Enhance properties value helper for NodeJS Enabler
  • Enhance properties value helper for Static Onboarding Enabler
  • Enhance properties value helper for Direct call to Eureka
  • Double check whether an enhancement in the validation of all the onboarding methods is possible
  • Write Js unit tests (using React Testing Library rather than Enzyme)
  • Update the documentation (if necessary) (will be done in a separate PR)

Linked to #1879 and #2059

Type of change

Please delete options that are not relevant.

  • (feat) New feature (non-breaking change which adds functionality)
  • (docs) Change in a documentation

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation (will be done in a separate PR)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@taban03 taban03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small note about the the tooltips. Could you change e.g. to Example:?
It would allow to be consistent with the other already existing tooltips

@taban03
Copy link
Contributor

taban03 commented Mar 22, 2022

In the wizard_spring_categories.jsx, you may want to add When the value is true, the Gateway allows encoded characters to be part of URL requests redirected through the Gateway. The default setting of false is the recommended setting. Change this setting to true only if you expect certain encoded characters in your application's requests. as a tooltip under the enableUrlEncodedCharacters.

@CaioCamatta CaioCamatta marked this pull request as ready for review March 24, 2022 22:14
@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 29, 2022
@balhar-jakub balhar-jakub changed the title Add missing tooltips to all onboarding options feat: Add missing tooltips to all onboarding options Mar 29, 2022
Signed-off-by: at670475 <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Mar 29, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
9.5% 9.5% Duplication

Copy link
Contributor

@taban03 taban03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@taban03 taban03 merged commit 5446fd5 into v2.x.x Mar 29, 2022
@delete-merged-branch delete-merged-branch bot deleted the apiml/GH1879_wizard_enhancement_improve_suggestions_2.x.x branch March 29, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants