Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exchange client certificate for SAF IDT #2455

Merged
merged 3 commits into from
Jun 21, 2022
Merged

Conversation

achmelo
Copy link
Member

@achmelo achmelo commented Jun 20, 2022

Description

Cherrypick remaining commits from v1.

Linked to #2366

Type of change

Please delete options that are not relevant.

  • (fix) Bug fix (non-breaking change which fixes an issue)
  • (feat) New feature (non-breaking change which adds functionality)
  • (docs) Change in a documentation
  • (refactor) Refactor the code
  • (chore) Chore, repository cleanup, updates the dependencies.
  • (BREAKING CHANGE or !) Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@zowe-robot zowe-robot added the Sensitive Sensitive change that requires peer review label Jun 20, 2022
weinfurt and others added 2 commits June 20, 2022 10:41
Signed-off-by: achmelo <[email protected]>
* Replace localca.cer

Signed-off-by: at670475 <[email protected]>

* fix

Signed-off-by: at670475 <[email protected]>

* revert

Signed-off-by: at670475 <[email protected]>

* use certificate for dev instance

Signed-off-by: at670475 <[email protected]>
Signed-off-by: achmelo <[email protected]>
Signed-off-by: achmelo <[email protected]>
@achmelo achmelo changed the title feat: Generate and verify SAF IDT with APPL keyword feat: exchange client certificate for SAF IDT Jun 20, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.0% 94.0% Coverage
0.0% 0.0% Duplication

@achmelo achmelo merged commit 303087c into v2.x.x Jun 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the rip/ac/complete_mtls branch June 21, 2022 06:51
CarsonCook pushed a commit that referenced this pull request Jun 28, 2022
* resolve conflicts

Signed-off-by: achmelo <[email protected]>

* fix: Use valid localca.cer (#2384)

* Replace localca.cer

Signed-off-by: at670475 <[email protected]>

* fix

Signed-off-by: at670475 <[email protected]>

* revert

Signed-off-by: at670475 <[email protected]>

* use certificate for dev instance

Signed-off-by: at670475 <[email protected]>
Signed-off-by: achmelo <[email protected]>

* remove unused imports

Signed-off-by: achmelo <[email protected]>

Co-authored-by: Petr Weinfurt <[email protected]>
Co-authored-by: Andrea Tabone <[email protected]>
achmelo added a commit that referenced this pull request Jun 29, 2022
* Fix simple smells

Signed-off-by: Carson Cook <[email protected]>

* feat: exchange client certificate for SAF IDT (#2455)

* resolve conflicts

Signed-off-by: achmelo <[email protected]>

* fix: Use valid localca.cer (#2384)

* Replace localca.cer

Signed-off-by: at670475 <[email protected]>

* fix

Signed-off-by: at670475 <[email protected]>

* revert

Signed-off-by: at670475 <[email protected]>

* use certificate for dev instance

Signed-off-by: at670475 <[email protected]>
Signed-off-by: achmelo <[email protected]>

* remove unused imports

Signed-off-by: achmelo <[email protected]>

Co-authored-by: Petr Weinfurt <[email protected]>
Co-authored-by: Andrea Tabone <[email protected]>

* Clean up unit test suite

Signed-off-by: Carson Cook <[email protected]>

* Fix smells

Signed-off-by: Carson Cook <[email protected]>

* chore: update minor snapshot version (#2459)

Signed-off-by: achmelo <[email protected]>

* include nested class in zosmflogintest scope (#2462)

Signed-off-by: achmelo <[email protected]>

* [skip ci] Update version

* [Gradle Release plugin] [skip ci] Before tag commit 'v2.2.0'.

* [Gradle Release plugin] Create new version: 'v2.2.1-SNAPSHOT'.

* Install dev dependencies in images (#2465)

Signed-off-by: Carson Cook <[email protected]>

* chore: provide epic number in PR (#2464)

Signed-off-by: achmelo <[email protected]>

* chore: tomcat security update (#2472)

Signed-off-by: achmelo <[email protected]>

* Remove generic wildcard

Signed-off-by: Carson Cook <[email protected]>

* Remove overriding upper scope var

Signed-off-by: Carson Cook <[email protected]>

* Remove use of deprecated function

Signed-off-by: Carson Cook <[email protected]>

* Remove generic wildcard

Signed-off-by: Carson Cook <[email protected]>

* Replace deprecated isEmpty

Signed-off-by: Carson Cook <[email protected]>

* Make field serializable

Signed-off-by: Carson Cook <[email protected]>

* Refactor long method signature to builder

Signed-off-by: Carson Cook <[email protected]>

* Remove deprecated classes

Signed-off-by: Carson Cook <[email protected]>

Co-authored-by: achmelo <[email protected]>
Co-authored-by: Petr Weinfurt <[email protected]>
Co-authored-by: Andrea Tabone <[email protected]>
Co-authored-by: Zowe Robot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sensitive Sensitive change that requires peer review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants