Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retrieve swagger api docs with or without certificate config enabled #2500

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

AmandaDErrico
Copy link
Contributor

@AmandaDErrico AmandaDErrico commented Jul 15, 2022

Signed-off-by: Amanda D'Errico [email protected]

Description

secureHttpClientWithoutKeystore is needed to handle GET requests to all swaggerUrls, especially when server certificates are being used as client certificates in client authentication.

Linked to # (2318)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • (fix) Bug fix (non-breaking change which fixes an issue)
  • (feat) New feature (non-breaking change which adds functionality)
  • (docs) Change in a documentation
  • (refactor) Refactor the code
  • (chore) Chore, repository cleanup, updates the dependencies.
  • (BREAKING CHANGE or !) Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@sonarcloud
Copy link

sonarcloud bot commented Jul 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@AmandaDErrico AmandaDErrico marked this pull request as ready for review July 15, 2022 12:58
@achmelo achmelo merged commit 16ca734 into v2.x.x Jul 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the apiml/GH2318/fix_zosmf_swagger_retrieval branch July 18, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants