Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Eureka peer connections loop #2775

Merged
merged 13 commits into from
Feb 8, 2023
Merged

Conversation

JirkaAichler
Copy link
Contributor

@JirkaAichler JirkaAichler commented Feb 1, 2023

Fix the Eureka peer connections loop

Type of change

Please delete options that are not relevant.

  • (fix) Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

Pablo Hernán Carle added 2 commits February 2, 2023 10:49
wip
Signed-off-by: Pablo Hernán Carle <[email protected]>
wip
Signed-off-by: Pablo Hernán Carle <[email protected]>
Copy link
Contributor

@pablocarle pablocarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@sonarcloud
Copy link

sonarcloud bot commented Feb 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

98.3% 98.3% Coverage
0.0% 0.0% Duplication

@JirkaAichler JirkaAichler merged commit 85a27ea into v2.x.x Feb 8, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-eureka-connection-loop branch February 8, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants