Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

Add removeKnownProperty method to ProfileInfo API #917

Closed
t1m0thyj opened this issue Dec 19, 2022 · 2 comments · Fixed by #920
Closed

Add removeKnownProperty method to ProfileInfo API #917

t1m0thyj opened this issue Dec 19, 2022 · 2 comments · Fixed by #920
Labels
enhancement New feature or request good first issue Good for newcomers priority-medium Not functioning - next quarter if capacity permits

Comments

@t1m0thyj
Copy link
Member

  • Update the type here to include undefined: IProfArgValue | undefined
  • Add a removeKnownProperty method to the ProfileInfo class. The implementation should be simple - call updateKnownProperty with value: undefined.

Regarding the IProfArgValue type, I think that adding an undefined is a good 'quick fix', but I'm wondering if it would be clear enough for others that setting the value to undefined will actually remove the property.

In my opinion, introducing a method like removeKnownProperty is self-explanatory and it's implementation could be as simple as calling the updateKnownProperty method with value undefined as any.

Originally posted by @juleskreutzer in zowe/zowe-cli#1561 (reply in thread)

@t1m0thyj t1m0thyj added good first issue Good for newcomers enhancement New feature or request priority-medium Not functioning - next quarter if capacity permits labels Dec 19, 2022
@juleskreutzer
Copy link
Contributor

@t1m0thyj Do you want me to open a PR for this?

@t1m0thyj
Copy link
Member Author

@t1m0thyj Do you want me to open a PR for this?

Sure, feel free to work on this issue 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers priority-medium Not functioning - next quarter if capacity permits
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants