Bindings cleanup v2 #105
Merged
Bindings cleanup v2 #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaking change allows to remove runtime cost for these bindings and makes the API clearer (removed a variant type)
Names of raw JS functions, raw JS bindings only used internally or raw JS types only used in internal bindings are now ending with 'Raw' renamed _convertObj to convertObj Removed _cleanObjectFromUndefined and _cleanVariables from .rei file since they were not used switched from let to external in ReasonRelay.rei for bindings without runtime cost
This allows a more robust type-check and avoids undefined fields in JS objects
|
This is great, thank you! 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to
bs.asallowingundefinedin BS 8.2.0 I changed the API forunsetValuefunctions tosetValueToNull/SetValueToUndefinedwhich is a bit nicer to use I think and allows 0 runtime cost bindings.I also cleaned the bindings again, used the naming convention we agreed on for internal raw types and functions, and use bs.obj and bs.deriving abstract instead of Js.t objects to have a more robust type-check and to avoid undefined fields in objects.
I think we're pretty close to not having to clean objects to remove undefined fields, maybe all that's left is to change the type of connections.
The next round of cleanup could be focused on reducing the number of
Currycalls in the generated JS.