Support for @inline fragments

[Arnarkari93]

How would reason-relay tackle supporting inline fragments? So non-react function can take advantage of data masking and getting correct reason types?

I tried binding it myself but was not successful since I could not find out how to get the module type that [%relay.fragment]

[zth]

@inline should work as-is now already, is it not? Or are you referring to readInlineData, which would allow you to read a fragment via a fragment ref outside of render/not via a hook?

[Arnarkari93]

Yes, I am referring to readInlineData.

[zth]

Let me try and bind it real quick and get back to you... 😄

[Arnarkari93]

This is as far as I got.

module type OperationType = {
   type fragment;
}

module type Operation = {
  type fragmentRef; 
  type operationType; 
  let node: ReasonRelay.fragmentNode;
  module Types: OperationType;
};

module ReadInlineData = (Operation: Operation) => {
  [@bs.module "react-relay"]
  external readInlineData:
    (ReasonRelay.fragmentNode, Operation.fragmentRef) => Operation.Types.fragment =
    "readInlineData";

  let read = (fragmentRef) => readInlineData(Operation.node, fragmentRef);
};

But I cant get type type ReasonRelay.fragmentRefs(|> Some fragment )

[zth]

I think what we should do isn't binding it in general, but rather generate code for it via the generated fragment module only when the fragment has @inline defined. So the API for using it would be roughly:

module Fragment =  [%relay.fragment {|
  fragment SomeUser_user on User @inline {
    ...
  }
|}];

let logData = user  => {
  SomeLoggingModule.log(Fragment.readInline(user));
);

Are you following how I'm thinking? I'll give it a try now and see if I can get it together real quick.

[Arnarkari93]

Yes, I follow, so we need to add it in the ppx, that's where you lose me 😬

[Arnarkari93]

I am not that comfortable adding it to ppx but I am willing to try.

[zth]

Give me a few minutes here and I'll have something you can review and hopefully get some insight on my thinking around adding stuff to the PPX, and then I can guide you through doing it yourself for the next feature we want to bind that touches the PPX, if you're interested?

[Arnarkari93]

yes! very interested.

[zth]

Check this out: https://github.com/zth/reason-relay/compare/bind-read-inline

Is that making sense?

I haven't actually tested it yet so it might not work 😅

[zth]

...I'm making a few changes to that, bear with me a few more minutes.

[Arnarkari93]

This looks good to me! Thank you for responding so quickly! I will try it out locally when I get a change.

[zth]

Implemented in #117