Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle legacy !gravatar images (img.message_body_gravatar) #963

Open
gnprice opened this issue Sep 25, 2024 · 0 comments
Open

Handle legacy !gravatar images (img.message_body_gravatar) #963

gnprice opened this issue Sep 25, 2024 · 0 comments
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents
Milestone

Comments

@gnprice
Copy link
Member

gnprice commented Sep 25, 2024

Up until 2020 (Zulip 3.0), Zulip Markdown had a syntax !gravatar(…), which produced elements like <img class="message_body_gravatar">. We don't currently support this content feature.

Server commit removing the feature: zulip/zulip@912e372
Server commit adding it (2012-10, when Zulip was two months old): zulip/zulip@c31462c
Example message

Although the feature was removed in Zulip 3.0 and we only support much newer servers, existing messages from years ago still have it in their HTML. So we should either support this feature, or get existing instances migrated on the server to modern syntax. The feature isn't a high priority, though.

Found by @PIG208 with the survey #917 / #190.

@gnprice gnprice added the a-content Parsing and rendering Zulip HTML content, notably message contents label Sep 25, 2024
@gnprice gnprice added this to the Post-launch milestone Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents
Projects
Status: No status
Development

No branches or pull requests

1 participant