Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More sophisticated system for uploading images #3271

Closed
borisyankov opened this issue Jan 11, 2019 · 1 comment
Closed

More sophisticated system for uploading images #3271

borisyankov opened this issue Jan 11, 2019 · 1 comment

Comments

@borisyankov
Copy link
Contributor

Sending an image message takes two steps:

  • uploading the image
  • sending the message with the image

Two problems with that:

  • If the first step fails, the upload is never retried
  • we show a message preview only after the image upload succeeds, which is the longer part of the process

Ideally, we will track all image uploads and retry them if they fail.

@gnprice
Copy link
Member

gnprice commented Jan 21, 2020

This is a multi-issue issue, which is better tracked as separate issues. (Something like this could be useful if describing work on a specific system to address the issues, but this one never functioned as that.)

The lack of a preview or other feedback is #2684. For the retry, I'm dubious that just always retrying is the right thing anyway. #3829 describes the foundational thing I think we want here, for messages in general; and we can file specific issues for further upload-specific wrinkles as we get into them.

@gnprice gnprice closed this as completed Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants