Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust test and code locations to match (UI) #1508

Open
neiljp opened this issue May 30, 2024 · 3 comments
Open

Adjust test and code locations to match (UI) #1508

neiljp opened this issue May 30, 2024 · 3 comments

Comments

@neiljp
Copy link
Collaborator

neiljp commented May 30, 2024

Description of suggested feature

I just closed #422, which as a move/split PR was long outdated and partially replaced by already-merged changes.

However, at some point it would likely still be useful to make changes such as:

  • move view element tests (eg. StreamsView, MessagesView) from ui/test_ui_tools into ui_tools/test_views (matching existing code positions)
  • split popup code out from ui_tools/views into ui_tools/popups (matching existing test split)

This has been discussed previously, and would help the developer experience in terms of locating matching code to tests and vice versa, but we help off at times due to conflicting open PRs.

In the past we have often started new work in a new file, and later moved code or tests around to join it.

@zulipbot
Copy link
Member

Hello @zulip/server-refactoring members, this issue was labeled with the "area: refactoring" label, so you may want to check it out!

@Ajnus
Copy link
Collaborator

Ajnus commented Oct 2, 2024

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Oct 2, 2024

Hello @Ajnus!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants