You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just closed #422, which as a move/split PR was long outdated and partially replaced by already-merged changes.
However, at some point it would likely still be useful to make changes such as:
move view element tests (eg. StreamsView, MessagesView) from ui/test_ui_tools into ui_tools/test_views (matching existing code positions)
split popup code out from ui_tools/views into ui_tools/popups (matching existing test split)
This has been discussed previously, and would help the developer experience in terms of locating matching code to tests and vice versa, but we help off at times due to conflicting open PRs.
In the past we have often started new work in a new file, and later moved code or tests around to join it.
The text was updated successfully, but these errors were encountered:
Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.
If this is your first time here, we recommend reading our guide for new contributors before getting started.
Description of suggested feature
I just closed #422, which as a move/split PR was long outdated and partially replaced by already-merged changes.
However, at some point it would likely still be useful to make changes such as:
This has been discussed previously, and would help the developer experience in terms of locating matching code to tests and vice versa, but we help off at times due to conflicting open PRs.
In the past we have often started new work in a new file, and later moved code or tests around to join it.
The text was updated successfully, but these errors were encountered: