Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement bialgebra in the other direction #20

Closed
Tracked by #317
y-richie-y opened this issue May 22, 2023 · 2 comments · Fixed by #74
Closed
Tracked by #317

Implement bialgebra in the other direction #20

y-richie-y opened this issue May 22, 2023 · 2 comments · Fixed by #74
Labels
Category: Proof mode Issues and enhancements related to Proof mode Priority: Medium Type: enhancement New feature or request

Comments

@y-richie-y
Copy link
Collaborator

Right now we can only apply bialgebra in only one direction, which reduces the number of nodes.
Sometimes the other direction is desirable.
@jvdwetering jvdwetering added the Type: enhancement New feature or request label Jun 6, 2023
@RazinShaikh RazinShaikh linked a pull request Aug 8, 2023 that will close this issue
Custom rewrites #74
Merged
@RazinShaikh RazinShaikh mentioned this issue Nov 19, 2023
Open
@RazinShaikh
Copy link
Collaborator

I closed this issue when I implemented custom rewrites in zxlive. But since the custom rewrites do not yet support rewrites with dots or arbitrary arity (see #109 ), it is still useful to implement this version of bialgebra. So I am reopening this issue.

@RazinShaikh RazinShaikh reopened this Jul 10, 2024
@RazinShaikh RazinShaikh added Category: Proof mode Issues and enhancements related to Proof mode Priority: Medium labels Jul 10, 2024
@RazinShaikh RazinShaikh mentioned this issue Jul 10, 2024
Open
35 tasks
@RazinShaikh
Copy link
Collaborator

Implemented in f1f15a6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Proof mode Issues and enhancements related to Proof mode Priority: Medium Type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Custom rewrites zxcalc/zxlive
3 participants
@y-richie-y @jvdwetering @RazinShaikh