Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaced concat of strings #1785

Merged
merged 1 commit into from
Apr 2, 2024
Merged

replaced concat of strings #1785

merged 1 commit into from
Apr 2, 2024

Conversation

igeni
Copy link
Contributor

@igeni igeni commented Mar 22, 2024

replaced concat of strings to avoid potential mismatch of types and make code more clear

@qdm12
Copy link
Contributor

qdm12 commented Mar 26, 2024

replaced concat of strings to avoid potential mismatch of types

Why would there be a mismatch of types though? 🤔

imartinez
imartinez approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@imartinez imartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major impact but definitely a source code improvement. Thanks!

@imartinez imartinez merged commit bac818a into zylon-ai:main Apr 2, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Apr 2, 2024
Merged
mrepetto-certx pushed a commit to mrepetto-certx/privateGPT that referenced this pull request Apr 18, 2024
@igeni @mrepetto-certx
feat(code): improve concat of strings in ui (zylon-ai#1785)
b6f2b0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imartinez imartinez imartinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igeni @qdm12 @imartinez