Fixed "no such group" error in Dockerfile, added docx2txt and cryptography deps #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o docx parsing works out of the box for docker containers
dividebysandwich
changed the title
imartinez
approved these changes
Apr 19, 2024
drupol
reviewed
Apr 21, 2024
| @@ -13,6 +13,8 @@ injector = "^0.21.0" | |||
| pyyaml = "^6.0.1" | |||
| watchdog = "^4.0.0" | |||
| transformers = "^4.38.2" | |||
| docx2txt = "^0.8" | |||
| cryptography = "^3.1" | |||
There was a problem hiding this comment.
This new line is breaking local installation:
> Checking runtime dependencies for private_gpt-0.5.0-py3-none-any.whl
> - cryptography<4.0,>=3.1 not satisfied by version 42.0.5
FYI, the current cryptography package is at version 42.
There was a problem hiding this comment.
I did not try it with version 42. I used 3.1 because that was specifically requested by other dependencies. I can give that a go tomorrow. But I tested both local installs and Docker on a blank VM and both worked. Still, using a more current version is probably better so I'll check if that works, of if the newest version causes any problems.
There was a problem hiding this comment.
Cool, looking forward for that!
Appears to work fine.
See dividebysandwich@ef51645 - but I haven't tested very thoroughly. Please let me know if this solves your problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a docker container was giving me a "No such group" error for the worker group. This has been fixed.
Also, I have added docx2txt to poetry, so users no longer get the error that docx2txt is not installed when running privategpt in a docker container.
cryptography has been added as well to remove the error when trying to parse certain PDF files.