ci: fix warnings and PR build #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalvkusk
added a commit
that referenced
this pull request
Feb 21, 2024
kalvkusk
added a commit
that referenced
this pull request
Feb 22, 2024
* Update networks.ts Added fallback nodes and modified initNetwork for better functionality and enhanced test flows * Update networks.ts Should ensure that the defaultPlaylist function is correctly returning a NetworkPlaylist object with the default network settings. * Update networks.ts Added fallback nodes and modified initNetwork for better functionality and enhanced test flows And modified the code to follow better practices for the defaultPlaylist and updateNetwork functions, to hopefully run better and not be caught by the linters * ci: fix warnings and PR build (#232) * CI: Fix warnings, add PR Build check * ci: mocked keys * Update networks.ts Fallbacks for the playlist with network functionality deferred to rust * Update networks.ts Replaced get with fetch and bypassed the http calls by retuning the embedded node list directly as it matches the expected behavior in rust --------- Co-authored-by: Kalvis Kuskis <[email protected]>
kalvkusk
added a commit
that referenced
this pull request
Feb 29, 2024
* ci: fix warnings and PR build (#232) (#237) * CI: Fix warnings, add PR Build check * ci: mocked keys * feat: get privatekey (#236) * fix: linter errors * bump canary version * Node playlists (#238) * Update networks.ts Added fallback nodes and modified initNetwork for better functionality and enhanced test flows * Update networks.ts Should ensure that the defaultPlaylist function is correctly returning a NetworkPlaylist object with the default network settings. * Update networks.ts Added fallback nodes and modified initNetwork for better functionality and enhanced test flows And modified the code to follow better practices for the defaultPlaylist and updateNetwork functions, to hopefully run better and not be caught by the linters * Update networks.ts Fallbacks for the playlist with network functionality deferred to rust * bump canary version * Node playlists (#239) * Update networks.ts Added fallback nodes and modified initNetwork for better functionality and enhanced test flows * Update networks.ts Should ensure that the defaultPlaylist function is correctly returning a NetworkPlaylist object with the default network settings. * Update networks.ts Added fallback nodes and modified initNetwork for better functionality and enhanced test flows And modified the code to follow better practices for the defaultPlaylist and updateNetwork functions, to hopefully run better and not be caught by the linters * Update networks.ts Fallbacks for the playlist with network functionality deferred to rust * Update networks.ts Replaced get with fetch and bypassed the http calls by retuning the embedded node list directly as it matches the expected behavior in rust * chore: make things pretty * Node playlists (#240) * Update networks.ts Added fallback nodes and modified initNetwork for better functionality and enhanced test flows * Update networks.ts Should ensure that the defaultPlaylist function is correctly returning a NetworkPlaylist object with the default network settings. * Update networks.ts Added fallback nodes and modified initNetwork for better functionality and enhanced test flows And modified the code to follow better practices for the defaultPlaylist and updateNetwork functions, to hopefully run better and not be caught by the linters * ci: fix warnings and PR build (#232) * CI: Fix warnings, add PR Build check * ci: mocked keys * Update networks.ts Fallbacks for the playlist with network functionality deferred to rust * Update networks.ts Replaced get with fetch and bypassed the http calls by retuning the embedded node list directly as it matches the expected behavior in rust --------- Co-authored-by: Kalvis Kuskis <[email protected]> * Fix transfers for rotated authkeys (#241) * Revert "Fix transfers for rotated authkeys (#241)" (#242) This reverts commit 43644ba. * Fix mining issue (#244) * fix: signingAccount data not synchronized (#225) * fix: mining UI issue (#193) * fix: mining issue (#225 #224 #213 #210 #207 #204 #191 #190) * fix: form submit issue (#208) * feat: Copy address to clipboard (#248) * fix: Compatible with chain_name in libra.yaml and chain_id in TS code. * feat: Copy address to clipboard * fix: when MINER is on, it accidentally switches accounts (#219) (#253) --------- Co-authored-by: BBK <[email protected]> Co-authored-by: teisnilsson <[email protected]> Co-authored-by: Zaki Manian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.