Refactored some unwrap commands #1163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactored two unwraps in account.rs create_manifest returns result accept results in manifest.rs and wizard_ OKs added Update wizard_fork_cmd.rs Update wizard_fork_cmd.rs match number 2 Update fix_cmd.rs updated matches Update wizard_val_cmd.rs Update wizard_val_cmd.rs cleaned account.rs Update account.rs Update account.rs Update account.rs Update account.rs Update account.rs Multiple files Update account.rs block.rs Update account.rs Update account.rs Update account.rs Update account.rs Update wizard_fork_cmd.rs Update account.rs Update account.rs Update account.rs Update account.rs Update account.rs Update account.rs Update whoami_cmd.rs Update whoami_cmd.rs Update whoami_cmd.rs valconfig Update manifest.rs Update wizard_fork_cmd.rs Update wizard_fork_cmd.rs Update wizard_fork_cmd.rs Update wizard_user_cmd.rs Update wizard_user_cmd.rs Update wizard_val_cmd.rs Update wizard_val_cmd.rs Update wizard_val_cmd.rs Update manifest.rs Update manifest.rs Update account.rs Update wizard_fork_cmd.rs Update wizard_fork_cmd.rs removed OKs removed error Update account.rs Update account.rs Update account.rs Update account.rs Update account.rs Update account.rs Update account.rs Update account.rs Update account.rs Update account.rs Update account.rs Update account.rs Update account.rs Update account.rs Update account.rs Update account.rs Update account.rs Update wizard_user_cmd.rs option Update block.rs Update block.rs config Update config.rs Update config.rs Update config.rs Update config.rs Update config.rs Update config.rs Refactored unrwap statements in in account.rs, block.rs and config.rs Refactored unrwap statements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored unwrap statements in account.rs, block.rs and config.rs within ol.
The work is far from finished, but as these are my first baby steps with Rust, I rather commit something smaller to get early feedback on the things that I did not get right yet. If you find it to be a total mess, you can provide general feedback instead of going through all changes. Then I am going to redo it accordingly.
Test Plan
I compiled the code, ran the onboarding wizard to generate the config files and the first proof, created a validator node, started node, tower and web monitor. All worked without problems on Ubuntu 20.04, AMD processor.