v6: Merkle tree hashing #1223
Open
v6: Merkle tree hashing #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One issue with this PR is that it uses |
|
This is stellar Move code! Hat's off! We have a user here @coin1111 that has implemented a early version of an eth bridge. For that he created a "native function" with keccak. Although, oddly I don't see it in V6, so I think it was ignored with the migration. Anyhow. Perhaps you want to pull in the XHASH module from V5, see below. And secondly, you might want to review the bridge code. Although, where we are today, it seems more likely that axelar would be the first bridge on 0L. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implements
Keccak(sha3-256) based Merkle Tree hashing.Note: Also includes fixes to
VoteTests.Test Plan
cargo test --test move_unit_testRelated PRs
#627