Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dpn test fixes #1224

Open
wants to merge 7 commits into
base: v6
Choose a base branch
from
Open

Dpn test fixes #1224

wants to merge 7 commits into from

Conversation

corynthian
Copy link

Motivation

Most of the tests in DPN (which should probably be renamed to ol-framework) fail. This PR addresses some of the more trivial fixes but others warrant a more thorough review (e.g. DiemAccount changes).

Test Plan

cargo test --release in DPN root.

Related PRs

(not sure)

corynthian and others added 4 commits January 23, 2023 16:54
@corynthian
dpn-test-fixes: Commented out some of the tests which fail in order t…
5ba00a8 
…o prioritise other failing tests.
@corynthian
dpn-test-fixes: Added error generation back, fixed some tests.
9816802
@simsekgokhan
Genesis v6 from JSON v5 export and v5 JSON export (0LNetworkCommunity…
3163e80 
…#1212)

* Implementing ol-genesis recover option (create JSON file with account data from snapshot)

* Fix Move error when "Set the validator operator for each validator owner" in fn recovery_owners_operators

* Implementing ol-genesis "recover from JSON" option (create genesis blob from JSON file with accounts)

* Do not ignore mv files

* Diem-framework must be built in diem-move/diem-framework dir.

* Build artifacts

* Reverting 0L change which causes the panic "Err value: unable to parse AccoutAddress"

* Refactoring

* Update Readme.md
@0o-de-lally
add cheatsheet for testing v6 (0LNetworkCommunity#1225)
4b40e86
@0o-de-lally
Copy link
Collaborator

This is a great fix. Especially ones related to roles.

Could you rebase with the latest changes, I wonder if there was some drift in the version you were working from.

Then please use this test command:

NODE_ENV="test" cargo test -p diem-framework --test ol_transactional_tests

# with your changes now the  default should work:
NODE_ENV="test" cargo test -p diem-framework --test transactional_tests

https://github.com/0LNetworkCommunity/libra/blob/v6/ol/documentation/core-devs/_V6_test_cheatsheet.md#run-functional-move-tests-aka-transactional-tests

@corynthian
Copy link
Author

Getting errors running the test command you provided. Something to do with missing arg --round in task command.

@0o-de-lally
Copy link
Collaborator

Getting errors running the test command you provided. Something to do with missing arg --round in task command.

Are you running this commandsfrom the project root?
NODE_ENV="test" cargo test -p diem-framework --test ol_transactional_tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corynthian @0o-de-lally @simsekgokhan