[txs] change balance_transfer API for Carpe app #990
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move the default init of txparams to a constructor * seprate the txparams type into a new module. place constructors in right place. change default behavior of initializing TX params, to find a good upstream from the list of upstream_nodes. * cargo fix * clear warnings * patch build * patch build * patch get_process * cli args patch * remove default_node from 0L.toml * rename upstream_nodes to rpc_fullnodes * patch tests * app configs documentation * grammar * make upstream_node not an option * build * limit backlog sending when miner has maxed current epoch proofs. * patch issue with swarm not making txs params * make MAX_PROOFS_PER_EPOCH pub * clean * patch test build error * backlog should exit with a TxError if can't evaluate tx status * scaffold tower error * patch build * patch build * change return type * patch build * display trait for towererror * format tower errors * Add tower error * add error code * add tower error * add lower bound mining thresh * patch defaults affecting integration tests * tower WrongDifficulty type * patch build * remove evil unwraps * remove annoying prints
[tools] rpc-playlist initialization with ol init
…NetworkCommunity#983) * adds documentation on how to set up a build environment for macOS * adds command to make setup script executable * dynamically determines library path for brew
|
@ea-open-source I've changed target branch for this PR. Can you resolve the conflicts? Thank you |
ea-open-source
force-pushed
the
carpe-build
branch
from
5cb8864
to
c96fbf3
Compare
|
Close this one due to incorrect source branch. New PR is here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current implementation of balance_transfer makes the app crash when invoked from Carpe app, possibly due to the call to get TxParams inside balance_transfer. So, this PR requires the calling code to directly pass TxParams parameter when invoking balance_transfer
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
You can run the following command
Related PRs
[cli] API for getting wallet type