Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new skirmish map Devils Horns #127

Merged
merged 5 commits into from
Jan 28, 2024
Merged

Conversation

perfecto25
Copy link
Contributor

new skirmish map - heavy terrain defense

@andy5995 andy5995 self-requested a review January 14, 2024 20:10
Copy link
Member

@andy5995 andy5995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome back and thanks for the submission. Looks like a 0ad convention is to use all lower-case characters in the filename.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this one as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perfecto25 I'd like to get your new map merged. Will you be able to rename this soon?

readme.md Outdated
@@ -66,6 +66,7 @@ of this repo.
| Alpine Rivers | [z4k](https://wildfiregames.com/forum/index.php?/profile/24112-z4k/) | [Forum](https://wildfiregames.com/forum/index.php?/topic/22929-sharing-users-map/) | 2017-12-09 |
| Battles in the Dirt | [Lion.Kanzen](https://wildfiregames.com/forum/index.php?/profile/13202-lionkanzen/) | [Forum](https://wildfiregames.com/forum/index.php?/topic/21613-battles-in-the-dirt/) | 2017-01-17 |
| Rapa Nui (Easter Island) | [Grapjas](https://wildfiregames.com/forum/index.php?/profile/21464-grapjas/) | [Forum](https://wildfiregames.com/forum/index.php?/topic/20674-you-guys-want-something-new-do-you-d-new-skirmish-mapupdated-to-v21/) | 2016-04-13 |
| Devil's Horns | perfecto25 | 2024-01-13 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Devil's Horns | perfecto25 | 2024-01-13 |
| Devil's Horns | perfecto25 | | 2024-01-13 |

Adding an extra column for the forum post link, otherwise the table is wrong:

image

Copy link
Member

@andy5995 andy5995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perfecto25 You can just hit "commit suggestion" if there's no forum post for this.

@andy5995 andy5995 merged commit b6d78dc into 0ad-matters:master Jan 28, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants