Merge pull request #14 from Dunedan/add-shellcheck-hook

Add a ShellCheck pre-commit hook
0ad · Dec 11, 2023 · b9616b2 · b9616b2
2 parents 0c14e6f + 1bc2efd
commit b9616b2
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -23,3 +23,8 @@ repos:
     rev: v6.14.2
     hooks:
       - id: ansible-lint
+
+  - repo: https://github.com/koalaman/shellcheck-precommit
+    rev: v0.9.0
+    hooks:
+      - id: shellcheck
diff --git a/roles/borgmatic/files/dump-ejabberd.sh b/roles/borgmatic/files/dump-ejabberd.sh
@@ -17,7 +17,7 @@ if [ "$PRIVATE_TMP_BACKUP_LOCATION" = "" ]; then
   exit 1
 fi
 
-if [ $(echo "$PRIVATE_TMP_BACKUP_LOCATION" | wc -l) -gt 1 ]; then
+if [ "$(echo "$PRIVATE_TMP_BACKUP_LOCATION" | wc -l)" -gt 1 ]; then
   echo "Something went wrong. Found more than one backup."
   exit 1
 fi

diff --git a/roles/ejabberd/files/create-self-signed-ejabberd-cert.sh b/roles/ejabberd/files/create-self-signed-ejabberd-cert.sh
@@ -22,13 +22,13 @@ keyUsage=digitalSignature
 extendedKeyUsage=serverAuth"
 EOF
 
-openssl req -x509 -out $TMP_DIR/$DOMAIN.crt -keyout $TMP_DIR/$DOMAIN.key \
+openssl req -x509 -out "$TMP_DIR/$DOMAIN.crt" -keyout "$TMP_DIR/$DOMAIN.key" \
   -newkey rsa:2048 -nodes -sha256 -days 90 \
   -subj "/CN=$DOMAIN" -extensions EXT -config "$TMP_DIR/config"
 
-cat $TMP_DIR/$DOMAIN.key > $TMP_DIR/$DOMAIN.pem
-cat $TMP_DIR/$DOMAIN.crt >> $TMP_DIR/$DOMAIN.pem
+cat "$TMP_DIR/$DOMAIN.key" > "$TMP_DIR/$DOMAIN.pem"
+cat "$TMP_DIR/$DOMAIN.crt" >> "$TMP_DIR/$DOMAIN.pem"
 
-chgrp ejabberd $TMP_DIR/$DOMAIN.pem
+chgrp ejabberd "$TMP_DIR/$DOMAIN.pem"
 
-mv $TMP_DIR/$DOMAIN.pem $TARGET_DIR/$DOMAIN.pem
+mv "$TMP_DIR/$DOMAIN.pem" "$TARGET_DIR/$DOMAIN.pem"