Disable SASL PLAIN authentication #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This disables the PLAIN mechanism for SASL authentication which would transmit a users password as plain text during. Instead only the SCRAM-SHA-1 and SCRAM-SHA-1-PLUS mechanisms are supported now. As SCRAM-SHA1 and SCRAM-SHA1-PLUS are mandatory to be supported by XMPP clients and servers and were prioritised higher than the PLAIN mechansim in the preference order by ejabberd before, this doesn't change how XMPP clients connect, but avoids unintentional use of the PLAIN mechanism in rare circumstances. Please note that these changes only affect authentication of registered users. During inband registration the password is still submitted in plain text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables the PLAIN mechanism for SASL authentication which would transmit a users password as plain text during. Instead only the SCRAM-SHA-1 and SCRAM-SHA-1-PLUS mechanisms are supported now.
As SCRAM-SHA1 and SCRAM-SHA1-PLUS are mandatory to be supported by XMPP clients and servers and were prioritised higher than the PLAIN mechansim in the preference order by ejabberd before, this doesn't change how XMPP clients connect, but avoids unintentional use of the PLAIN mechanism in rare circumstances.
Please note that these changes only affect authentication of registered users. During inband registration the password is still submitted in plain text.