Fix the maximum number of users in a MUC room #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The room option for max_users in a MUC room is capped to the maximum of the service level max_users option. As this option wasn't set, the maximum users per MUC room were limited to 200. This commit fixes that.
|
Did we reach that limit recently? |
|
Nope, that's just a precautionary measure. |
|
IIRC the server fell at like 400 but maybe the code has changed enough to support that now :) |
StanleySweet
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The room option for max_users in a MUC room is capped to the maximum of the service level max_users option. As this option wasn't set, the maximum users per MUC room were limited to 200. This commit fixes that.