Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli-utils): Support @vue/[email protected] changes #353

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

kitten
Copy link
Member

@kitten kitten commented Jul 30, 2024

Similar past change: #305

Summary

This supports changes in @vue/language-core which renamed getBasePlugins (again) to createPlugins, which caused Vue files to again not be parsed.

To prevent further delays in debugging such errors, there's now a check function that outputs an explicit error if VueVirtualCode or createPlugins are undefined, which is a pretty sure signal of breaking changes.

Set of changes

  • Upgrade internal test version of @vue/language-core
  • Fix @vue/language-core version, which was accidentally bumped (set to ~2.0.0)
  • Add check function with special error for breaking Vue changes

@kitten kitten requested a review from JoviDeCroock July 30, 2024 12:34
Copy link

changeset-bot bot commented Jul 30, 2024

🦋 Changeset detected

Latest commit: b484454

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.... Why....

Great find bud

@kitten kitten merged commit 4a7844f into main Jul 30, 2024
2 checks passed
@kitten kitten deleted the fix/vue-create-plugins branch July 30, 2024 13:00
@github-actions github-actions bot mentioned this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants