fix: Fix Safari 10–13 sticky regular expression quirks #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14
Summary
This resolves quirks that occur with Safari 10–13’s implementation of sticky regular expressions. It may not be a comprehensive fix, nor do I have an explanation for this.
The following regular expressions seem to match/test positively, when they shouldn't:
The last one in this list actually doesn't, which further confuses me.
Either way, they can all be fixed by slightly rewriting them.
Set of changes
constRe
's pattern in a non-capturing groupoperationDefinitionRe
's pattern in a non-capturing groupfloatPartRe
's pattern to strictly always be non-empty\w
more sparingly and accurately