Fix config #45
Merged
Fix config #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also changed time and priority labels from array of objects to array of strings
0x4007
reviewed
Nov 16, 2023
Comment on lines
+15
to
+23
| const orgConfig = parseYaml( | ||
| await download({ | ||
| context, | ||
| repository: UBIQUIBOT_CONFIG_REPOSITORY, | ||
| owner: payload.organization?.login || payload.repository.owner.login, | ||
| }) | ||
| ); | ||
|
|
||
| const repositoryConfiguration = parseYaml( | ||
| const repoConfig = parseYaml( |
There was a problem hiding this comment.
I prefer that you do not shorten words. The reason why is to reduce cognitive overhead when reading through all of the code.
0x4007
merged commit 62cb0c6
into
0x4007:feat/contributor-incentives-total-scoring
3 of 5 checks passed
|
@wannacfuture please sync your branch. |
0x4007
reviewed
Dec 20, 2023
| }), | ||
| { default: allCommands } | ||
| ), | ||
| disabledCommands: T.Array(T.String(), { default: allCommands }), |
There was a problem hiding this comment.
Perhaps it makes sense to enable all commands by default? It seems that disabling by default has always caused more headaches when starting new repos for us? rfc @whilefoo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pavlovcik I implemented the custom array merger so in case of strings it concats arrays and removes duplicates and in case of objects just concats.
I changed
commandstodisabledCommandsas array of strings and I changed time and priority labels to array of strings