Knip CI #57
Knip CI #57
Conversation
.github/workflows/knip.yml
Outdated
| run: yarn install | ||
|
|
||
| - name: Report knip results to pull request | ||
| uses: gitcoindev/[email protected] |
There was a problem hiding this comment.
Where can I see this source code?
There was a problem hiding this comment.
@pavlovcik it is available here: https://github.com/gitcoindev/knip-reporter
There was a problem hiding this comment.
Perhaps its best to place this under Ubiquity? Looks like they updated the code too.
There was a problem hiding this comment.
Let's wait a few days for the upstream pull request to be merged. If it will stall we'll move under Ubiquity, but since the author released knip-reporter with v3 support this week there is a high chance he will pick it up soon.
.github/workflows/knip.yml
Outdated
| - name: Setup Node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: "18.14.1" |
There was a problem hiding this comment.
good point, I will check with the latest LTS as well
There was a problem hiding this comment.
@pavlovcik I will test with latest LTS today and let you know asap.
There was a problem hiding this comment.
I rebased to latest knip v3 support in my fork, fixed the tests and opened a PR upstream https://github.com/Codex-/knip-reporter/pull/15 will try to push this, if this is accepted we will be able to use an official release.
There was a problem hiding this comment.
My pull request was extended and approved, merged upstream. I will now verify this on my fork and let you know if this works as expected.
There was a problem hiding this comment.
I spent quite some time on debugging and asked the author why it does not work as expected on latest upstream release https://github.com/Codex-/knip-reporter/issues/9#issuecomment-1853771495 but does work on my fork let's wait for his response.
There was a problem hiding this comment.
@pavlovcik after a few hours I found the culprit and solved the problem.
knip v3 does not work well with typescript < 5 , does not throw errors but its output json does not contain all needed data. I had to update ubiquibot's dev dependencies to typescript ^5.0.4 and jest + ts-jest to v29 and it works like a charm, annotations in action are visible in my qa at https://github.com/gitcoindev/ubiquibot/pull/17/files
It is a bit late for me today, I will check tomorrow if this did not break anything and will add the typescript and jest upgrade as well to refactor/general
❌ Deploy Preview for ubiquibot-production failed.
|
Version 2.1.0 released with export annotations support and additional tests.
node types Also set explicit anntations in knip.yml.
|
CI failed. What's the status on this? |
# Comment event received without a recognized user command. |
# Comment event received without a recognized user command. |
Permissions issue, I will try to reproduce on my org repo as on my fork it looks fine. |
@pavlovcik I think I found the root cause. I suspect that your fork's https://github.com/pavlovcik/ubiquibot settings restrict access for my pull requests to add / modify comments and would have to change 'Workflow permissions' settings
I will check if perhaps also permissions can be reduced, currently the yaml workflow file uses |
|
Okay I'll try later today |
|
Hi @pavlovcik I dug deeper to check why CI fails here. It fails because the pull request is opened from a fork to a fork and not to the original bot repository. This situation is described at https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/#improvements-for-public-repository-forks and https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks . I was able to reproduce the same permission issue in my personal fork https://github.com/gitcoindev/ubiquibot vs my org fork https://github.com/korrrba/ubiquibot as well. Therefore, once the pull request is merged into the original bot repository, the knip ci workflow will work correctly. |
Resolves #897
Quality Assurance:
a) Annotations: https://github.com/gitcoindev/ubiquibot/pull/17/files
b) PR comment: gitcoindev#17 (comment)
Screenshot: