Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix pricing issue #63

Conversation

wannacfuture
Copy link
Collaborator

No description provided.

Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for ubiquibot-production ready!

Name Link
🔨 Latest commit 30fafc9
🔍 Latest deploy log https://app.netlify.com/sites/ubiquibot-production/deploys/659d360755a6d700088bf170
😎 Deploy Preview https://deploy-preview-63--ubiquibot-production.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -74,10 +74,12 @@ export async function onLabelChangeSetPricing(context: Context): Promise<void> {
return;
}

if (!hasAssistivePricing) return;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that void returns are banned in favor of null. Are you sure this runs without issue?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, when I tried, there was no issue.

@0x4007
Copy link
Owner

0x4007 commented Jan 9, 2024

Make sure to fix CI. I think this was my fault. I spent an afternoon reading yarn docs and made some changes that seem out of sync with your fork.

@wannacfuture
Copy link
Collaborator Author

Make sure to fix CI. I think this was my fault. I spent an afternoon reading yarn docs and made some changes that seem out of sync with your fork.

What do you mean?
Do you what me to fix these things?
https://github.com/pavlovcik/ubiquibot/actions/runs/7460859175/job/20299792303?pr=63
https://github.com/pavlovcik/ubiquibot/actions/runs/7460775894/job/20299541209?pr=63
@pavlovcik

@0x4007
Copy link
Owner

0x4007 commented Jan 15, 2024

Make sure to fix CI. I think this was my fault. I spent an afternoon reading yarn docs and made some changes that seem out of sync with your fork.

What do you mean? Do you what me to fix these things? https://github.com/pavlovcik/ubiquibot/actions/runs/7460859175/job/20299792303?pr=63 https://github.com/pavlovcik/ubiquibot/actions/runs/7460775894/job/20299541209?pr=63 @pavlovcik

I vaguely remember what I did a few weeks ago but a good starting point to fix this is to check out https://yarnpkg.com/corepack

@0x4007
Copy link
Owner

0x4007 commented Jan 15, 2024

You can fix CI in a new PR

@0x4007 0x4007 merged commit 714ea60 into refactor/move-to-delegated-compute Jan 15, 2024
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants