-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fix pricing issue #63
feat: fix pricing issue #63
Conversation
✅ Deploy Preview for ubiquibot-production ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -74,10 +74,12 @@ export async function onLabelChangeSetPricing(context: Context): Promise<void> { | |||
return; | |||
} | |||
|
|||
if (!hasAssistivePricing) return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that void
returns are banned in favor of null
. Are you sure this runs without issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, when I tried, there was no issue.
Make sure to fix CI. I think this was my fault. I spent an afternoon reading yarn docs and made some changes that seem out of sync with your fork. |
What do you mean? |
I vaguely remember what I did a few weeks ago but a good starting point to fix this is to check out https://yarnpkg.com/corepack |
You can fix CI in a new PR |
714ea60
into
refactor/move-to-delegated-compute
No description provided.