-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yyj extraction hood device support #487
Conversation
thanks @JobDoesburg ! change range cause 2 problem, one is during the plugin upgrade, cache issue, second is I forgot why I'm doing this, must have a reason... |
The reason for the changed rotation speed is to properly reflect the current status in homekit. Without the change I propose, a fan can be running at "4%" which would be the max speed, and each step is 1%. That looks weird in homekit. It is more intuitive to have the max speed be 100%, the lowest speed (off) be 0% and have intermediate steps. That is what the "step" property is for. Do you have a suggestion for fixing the cache issue on upgrade? What is exactly the problem? |
Yes I agree with you, minstep=1 looks weird... |
The jjy part is good for me, I suggest we split the rotation speed code into another pr is that okay? Anyway thanks for the help :) |
c298d26
to
0beb65e
Compare
Hmm, also not entirely sure about this, but I remember HomeKit not displaying this properly everywhere (which would probably be a bug on Apple's side)
Definitely! |
Thanks again! |
Add support for an extraction hood device (air purifier + lightbulb).
Also changed the rotation speed property to properly display a 0% to 100% range (with larger steps), instead of 0% to 4% in case of 5 steps.