Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC201/205]: EVM-613-Change validator info command #1421

Conversation

goran-ethernal
Copy link
Collaborator

@goran-ethernal goran-ethernal commented Apr 24, 2023

Description

This PR changes the validator-info command that queries validator info from a smart contract, to query it from the root SupernetManager contract instead (since validator info is now saved on rootchain).

Through this PR we will not be fixing tests that use validator-info command. That PR will come later on.

IMPORTANT NOTE: e2e test will fail until we have all the new logic implemented. PR that fixes e2e tests will be the last one in the RFC-201/205 series.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@goran-ethernal goran-ethernal changed the title Change validator info command [RFC201/205]: EVM-613-Change validator info command Apr 24, 2023
@goran-ethernal goran-ethernal self-assigned this Apr 24, 2023
@goran-ethernal goran-ethernal added the breaking change Functionality that contains breaking changes label Apr 24, 2023
@goran-ethernal goran-ethernal marked this pull request as ready for review April 24, 2023 10:02
@goran-ethernal goran-ethernal merged commit 5b8b458 into feat/validator-storage-rework Apr 24, 2023
@goran-ethernal goran-ethernal deleted the EVM-613-Change-validator-info-command branch April 24, 2023 12:39
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change Functionality that contains breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants