-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC-201/205]: EVM-580-Update validator set in stake manager #1431
Merged
goran-ethernal
merged 20 commits into
feat/validator-storage-rework
from
EVM-580-Update-validator-set
Apr 26, 2023
Merged
[RFC-201/205]: EVM-580-Update validator set in stake manager #1431
goran-ethernal
merged 20 commits into
feat/validator-storage-rework
from
EVM-580-Update-validator-set
Apr 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goran-ethernal
changed the title
Initial changes
[RFC-201/205]: EVM-580-Update-validator-set-in-stake-manager
Apr 25, 2023
goran-ethernal
requested review from
vcastellm,
igorcrevar,
Nemanja0x,
Stefan-Ethernal and
stana-miric
April 25, 2023 13:43
goran-ethernal
changed the title
[RFC-201/205]: EVM-580-Update-validator-set-in-stake-manager
[RFC-201/205]: EVM-580-Update validator set in stake manager
Apr 25, 2023
igorcrevar
reviewed
Apr 25, 2023
igorcrevar
reviewed
Apr 25, 2023
igorcrevar
reviewed
Apr 25, 2023
igorcrevar
reviewed
Apr 25, 2023
igorcrevar
reviewed
Apr 25, 2023
igorcrevar
approved these changes
Apr 26, 2023
Nemanja0x
approved these changes
Apr 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new concept:
stakeManager
.stakeManager
does two things:syncer
orconsensus
) reads allTransfer
events from theValidatorSet
contract on child chain and saves them to thestakeChange
bucket inboltDB
for the epoch in which occurred (Transfer
events carry information about stake change of validators in given epoch).Transfer
events that happened in the previous epoch (epoch that is currently ending).PR also added UnitTests for
stakeManager
and its store that saves theTransfer
events toboltdb
.IMPORTANT NOTE:
e2e
tests will fail until all client logic is implemented. Fixing ofe2e
tests will be the last PR for RFC-201/205 saga.Changes include
Checklist
Testing